Repository navigation
Use current module paths for migrated imports - #120
Open
iamziyuzhao wants to merge 1 commit into
Open
iamziyuzhao wants to merge 1 commit into
iamziyuzhao wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The agent/task/environment refactors moved shared symbols, but framework callers, examples, and tests still imported them through the compatibility re-exports. Update 66 import statements (78 symbol references) across 51 Python files, including 24 imports in generated Python snippets, to use the current modules:
RunOutputandload_callable:hermit.task→hermit.common.Limits,Mount,Unsupported,as_environment):hermit.agent.base.interface→hermit.environment.as_messages:hermit.agent.base.interface→hermit.agent.model.direct.Update the migration table to name the current entry points. The original five deprecated module entry points (
hermit.agents,hermit.evolver,hermit.backends,hermit.llm,hermit.trajectory) already have zero active callers. Preserve all forwarding modules, public compatibility exports, historical migration notes, and the intentional compatibility tests.This is an import-only cleanup: no signatures, defaults, agent behavior, exception classes, sandbox boundaries, or test assertions change. Shared core files now import from their owning layers; method and example callers follow the same rule.
Validation
git diff --checkpassed.python -m pytest tests/core/test_task.py tests/core/test_layers.py -q: 9 passed.hermit check,hermit train, andhermit eval --adapter finalall exited 0. Training completed two steps; final evaluation scored 1.0 on two tasks with zero errors and $0 model cost.bash docs/build.sh: passed, with warnings treated as errors.python -m pytest --changed --durations=10 --tb=shorton macOS / Python 3.12: 1,658 passed, 240 skipped, 16 failed, 1 warning in 544.15 seconds. Ran from a space-free virtual environment with itsbinon PATH so the CLI stand-ins use the correct interpreter.b65a5c6in the same Python environment: all 16 failed again (9.35 seconds). No new failing test IDs were introduced. The failures concern unavailable bubblewrap/Linux/proc, missing optionalrrsi/harness2dependencies, and three existing virtual-environment interpreter assertions on this host. The one warning comes from the intentional deprecated-import compatibility test.--integration; ACE and other absent optional dependencies or prepared benchmark data may still skip.Review
--changedselects every group because shared core code and the toy-task helper changed.4226ed3, the completed local checks, and the base-branch failure comparison. CI is explicitly pending above.4226ed36adeac60d452639c107b9944d82d039e6. The published patch matches the locally reviewed change. No actionable code findings. Its one description correction—clarifying which checks CI skips—is incorporated above. The later completed local suite and base-branch failure comparison are recorded above; no code changed after the audit. CI, Linux, and real CLI limitations remain disclosed.